On 00:58 Tue 05 May , Wolfgang Denk wrote:
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20090504224128.GF13923@game.jcrosoft.org you wrote:
U-Boot does not currently build for PXA platforms with USB support enabled. This is due to commit 24e37645e7378b20fa8f20e2996c8fb8e9 which introduced the usage of UP2OCR without defining it.
Signed-off-by: Daniel Mack daniel@caiaq.de Cc: Markus Klotzbuecher mk@denx.de
NACK
UP2OCR is not avaaillable for the pxa2xx
we need to clean it really
So who is going to do that, and when?
BTW - how many PXA platforms with USB support do we have, and how many of these are pxa2xx ?
the usb driver use the same file for supporting all the PXA and as it's store in a generic header. We must define the register only the specific pxa version and when the same register could mean differents things depending the pxa version
That's the theory. Praxis is that we have a bug, and we need a fix. And we seem to have one.
You did not answer my questiosn:
- how many PXA platforms with USB support do we have?
nomahans and pxa27x IIRC for usb host
- how many of these are pxa2xx?
IIRC trizepsiv but other HW (mainline) can activate it also evenif they do not actually by default
In other words - is your concern a real problem, or just a theoretical one?
yes a real problem because you will have to deal with is latter anyway and it will take hours to debug. So do a quick dirty fix will not improve the situation at the end.
Also define a register the pxa specific is alread the principle fallow in this header
As far as I can tell, "delta" is the only PXA based board which has USB enabled. And this is not a pxa2xx.
which not mean that we do support the pxa2xx usb (trizepsiv)
Best Regards, J.