Dear Stefan Roese,
In message 1256906335-6477-1-git-send-email-sr@denx.de you wrote:
This patch introduces a weak default function for post_hotkey_pressed(), returning 0, for boards without hotkey support. The long-running tests won't be started on those boards. This default function was implemented in many board directories. By implementing this weak default we can remove all those duplicate versions.
Boards with hotkey support, can override this weak default function by defining one in their board specific code.
Hm... but the implementations were actually different. Some boards used ctrlc() so they would catch a (prebably previously pressed) ^C:
--- a/board/amcc/katmai/katmai.c +++ b/board/amcc/katmai/katmai.c
...
-int post_hotkeys_pressed(void) -{
- return (ctrlc());
-} -#endif
...while others unconditionally return 09, without checking for ^C:
--- a/board/amcc/kilauea/kilauea.c +++ b/board/amcc/kilauea/kilauea.c
...
-int post_hotkeys_pressed(void) -{
- return 0; /* No hotkeys supported */
-}
Are you sure the suggested change does not change the behavious on any of these boards?
Best regards,
Wolfgang Denk