Re: [U-Boot] [PATCH 2/3] clk: zynqmp: Dont panic incase of mmio write/read failures

On 20 July 2017 at 03:03, Michal Simek michal.simek@xilinx.com wrote:

From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com

Dont panic incase of mmio write/read failures instead return error and let the peripheral driver take care of clock get and set failures.

Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com

---

drivers/clk/clk_zynqmp.c | 63 +++++++++++++++++++++++++++++++++--------------- 1 file changed, 44 insertions(+), 19 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

But I suggest using debug() instead of printf() on error. This is a driver, after all.

Regards, Simon