Re: [U-Boot] [PATCH v3] Add support for the digsy MTC board.

Hi Grzegorz,

Grzegorz Bernacki wrote:

This is the InterControl custom device based on the MPC5200B chip.

Signed-off-by: Grzegorz Bernacki gjb@semihalf.com

Version 3:

• updated (c)

Version 2:

• use I/O accessor functions instead of volatile pointer
• set ethernet address only if not set in environment
• add some comments and some style cleanup

<snip>

diff --git a/drivers/net/mpc5xxx_fec.c b/drivers/net/mpc5xxx_fec.c index f8618b1..a1c72d6 100644 --- a/drivers/net/mpc5xxx_fec.c +++ b/drivers/net/mpc5xxx_fec.c @@ -893,6 +893,7 @@ int mpc5xxx_fec_initialize(bd_t * bis) fec->rbdBase = (FEC_RBD *)(FEC_BD_BASE + FEC_TBD_NUM * sizeof(FEC_TBD)); #if defined(CONFIG_CANMB) || \ defined(CONFIG_CM5200) || \

• defined(CONFIG_DIGSY_MTC) || \ defined(CONFIG_HMI1001) || \ defined(CONFIG_ICECUBE) || \ defined(CONFIG_INKA4X0) || \

No more adding to this mess, please. This absolutely belongs in board code. I know you're not responsible for it, so if you don't have time to clean it up I can do so and supply an untested patch.

<snip>

regards, Ben