On 10 October 2014 21:44, Tom Rini trini@ti.com wrote:
On Tue, Sep 30, 2014 at 10:48:11AM -0400, Tom Rini wrote:
On Tue, Sep 30, 2014 at 08:06:43PM +0530, Jagan Teki wrote:
On 30 September 2014 18:41, David Müller (ELSOFT AG) d.mueller@elsoft.ch wrote:
Jagan Teki wrote:
On 30 September 2014 16:53, David Müller d.mueller@elsoft.ch wrote:
+int board_early_init_f(void) +{
spi_init_f();Why you need to do this, spi_init_f is trying to call from arch/powerpc/lib/board.c any specific reason, I couldn't understand the fix you mentioned on the commit body.
There is an EEPROM attached to the SPI channel containing vital board data. Calling spi_init_f() from arch/powerpc/lib/board.c will be too late.
Sorry, this looks an other issue - but anyway we're trying to remove spi_init* stuff from drivers/spi/* in future and I don't think it's a good idea to use that.
It's also not a good idea to say that we'll leave a board broken until something better comes along. There should be a comment added to the code here making it clear _why_ we need this done early.
And again, for the record, I wanted to _fix_ things today so we can clean them up tomorrow, rather than keep something broken so we can fix it later.
OK, got your point.
thanks!