Hi Nikhil.
On Thursday 14 February 2008, Nikhil Gautam wrote:
Thanks for all the help in solving the problem. I have some questions about submitting the patch and testing of the patch.
First of all I am working on proprietary board based on AMCC sequoia board.
You need to create a new board port for your custom board. This could be done by "cloning" the Sequoia port and modifying it.
Hence some of the files I changed are module specific like config.mk in nand_spl/board/....and I also modified the following lines in u-boot-nand.lds
cpu/ppc4xx/start.o (.text) /* Align to next NAND block */ . = ALIGN(0x20000); common/environment.o (.ppcenv) /* Keep some space here for redundant env and potential bad env blocks*/ . = ALIGN(0x80000);
Above is to allow some space for u-boot environment and possible bad blocks. This file is also module specific.
Right. All this should *not* go into the Sequoia port but into your new board port. The infrastructure is ready for it.
Besides these two files I have changed nand_boot.c and ndfc.c.
Sure. These are probably the only common changes needed.
Considering all this, how should I create this patch. Should I create a patch for the sequoia board?
*NO*. Please don't. Create you own board port.
Also how are we going to test this patch? I'll make sure it meets all the requirement in terms of coding style, etc but as far as testing goes, I can only test on my board because sequoia reference board comes only with 256Mb NAND flash.
You will test this on your board and I (or somebody else) will test it on already supported NAND booting platforms.
Hope this helps.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================