Hi Simon,
-----Original Message----- From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass Sent: Monday, August 14, 2017 5:37 AM To: Peng Fan peng.fan@nxp.com Cc: Stefano Babic sbabic@denx.de; Peng Fan van.freenix@gmail.com; U- Boot Mailing List u-boot@lists.denx.de; Masahiro Yamada yamada.masahiro@socionext.com; Bin Meng bmeng.cn@gmail.com; Andre Przywara andre.przywara@arm.com; Cooper Jr., Franklin fcooper@ti.com; Álvaro Fernández Rojas noltari@gmail.com Subject: Re: [PATCH 03/12] Makefile: build FIT image if CONFIG_SPL_FIT_GENERATOR defined
Hi,
On 9 August 2017 at 03:16, Peng Fan peng.fan@nxp.com wrote:
Build FIT image if CONFIG_SPL_FIT_GENERATOR defined.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Simon Glass sjg@chromium.org Cc: Masahiro Yamada yamada.masahiro@socionext.com Cc: Bin Meng bmeng.cn@gmail.com Cc: Andre Przywara andre.przywara@arm.com Cc: "Cooper Jr., Franklin" fcooper@ti.com Cc: "Álvaro Fernández Rojas" noltari@gmail.com Cc: Stefano Babic sbabic@denx.de
Makefile | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile index 50a002e..fbe7714 100644 --- a/Makefile +++ b/Makefile @@ -804,6 +804,10 @@ ALL-y += u-boot-tegra.bin u-boot-nodtb-tegra.bin ALL-$(CONFIG_OF_SEPARATE) += u-boot-dtb-tegra.bin endif
+ifneq ($(CONFIG_SPL_FIT_GENERATOR),) +ALL-y += u-boot.itb +endif
I see .tbd but .fit is more common. Can we use .fit?
In the Makfile, there is u-boot.itb: u-boot-nodtb.bin dts/dt.dtb $(U_BOOT_ITS) FORCE $(call if_changed,mkfitimage)
Also in doc/uImage.FIT/*, files are named *.its and generated *.itb. If we change the file name to *.fit, many places needs to be updated. I prefer we keep *.itb here.
Thanks, Peng.
I
# Add optional build target if defined in board/cpu/soc headers ifneq ($(CONFIG_BUILD_TARGET),) ALL-y +=
$(CONFIG_BUILD_TARGET:"%"=%)
-- 2.6.2
Regards, Simon