Re: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library

Dear Kumar Gala,

In message FA771A99-42EA-4299-9DE1-77AFC32734B2@kernel.crashing.org you wrote:

...

...

+{

•   const unsigned long input_freq = CONFIG_ICS307_REFCLK_HZ;
  

•   unsigned long VDW = ((cw1 << 1) & 0x1FE) + ((cw2 >> 7) & 1);
  

•   unsigned long RDW = cw2 & 0x7F;
  

•   unsigned long OD = ics307_s_to_od[cw0 & 0x7];
  

•   unsigned long freq;
  

Wolfgang just asked me not to use camel caps.

where are there camel caps?

There aren't. But we do not allow for ALLCAPS identifiers either (these are reserved for macro names).

Best regards,

Wolfgang Denk