Hi Sam,
On 2023/7/26 05:40, Sam Edwards wrote:
Hi folks,
On 7/7/23 09:52, Yifan Zhao wrote:
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h index 4af7c91560..433a3c6c1e 100644 --- a/fs/erofs/internal.h +++ b/fs/erofs/internal.h +/* make sure that any user of the erofs headers has at least 64bit off_t type */ +extern int erofs_assert_largefile[sizeof(off_t) - 8];
This assertion does not hold true on 32-bit platforms, and as a result this patch prevents building U-Boot on those systems with EROFS support enabled. Did you perhaps mean to use `erofs_off_t` (which is always 64-bit) somewhere that you're using `off_t` instead?
I have had to revert this patch on my target, pending a solution for 32-bit users.
Thanks for your report.
I think this line could just be removed since it only impacts LFS APIs ["erofs-utils which uses _FILE_OFFSET_BITS=64"] directly: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit... https://lore.kernel.org/all/20221215085842.130804-1-raj.khem@gmail.com/
But EROFS userspace internal implementation doesn't use off_t directly (instead it uses erofs_off_t as you said) nor u-boot interfaces (I think).
Yifan, Could you submit a patch to remove this line?
Thanks, Gao Xiang
Thanks, Sam