30 Apr
2011
30 Apr
'11
6:58 a.m.
On Thursday, April 21, 2011 19:38:06 Wolfgang Denk wrote:
Simon Glass wrote:
- base_name - base name for device (NULL for "eth")
This is an atitifical decision for the API which is difficult to understand. It just makes the code and understanding it more difficult. Just pass "eth" when you mean it.
The intention was to avoid everyone having to pass the correct value - potential for error, etc. I could have created a #define, but decided on this.
Ummm... but having everyone to pass the correct value is actually a really good thing to have!
i'm not sure about that. it just means it's easier for people to screw it up, or for duplicated code to propagate via copy & paste. the current API Simon has makes sense to me. -mike