On Thu, Apr 25 2024, tkuw584924@gmail.com wrote:
From: Takahiro Kuwano Takahiro.Kuwano@infineon.com
I wonder how authorship should work for such patches. Patches 1, 2, and 6 in this series are very close to what my patches did for Linux. So I wonder who should get authorship in this case: the person porting the patch or the person who wrote the original one. Same for patch 5 but that is still a little more changed from its Linux counterpart.
For NOR flashes EC and VID are zeroed out before an erase is issued to make sure UBI does not mistakenly treat the PEB as used and associate it with an LEB.
But on some flashes, like the Infineon Semper NOR flash family, multi-pass page programming is not allowed on the default ECC scheme. This means zeroing out these magic numbers will result in the flash throwing a page programming error.
Do not zero out EC and VID for such flashes. A writesize > 1 is an indication of an ECC-ed flash.
This patch replicates the following upstream linux commit: f669e74be820 ("ubi: Do not zero out EC and VID on ECC-ed NOR flashes")
Acked-by: Tudor Ambarus tudor.ambarus@linaro.org Signed-off-by: Takahiro Kuwano Takahiro.Kuwano@infineon.com
Apart from my comment above,
Acked-by: Pratyush Yadav pratyush@kernel.org