-----Original Message----- From: Wood Scott-B07421 Sent: Thursday, June 07, 2012 2:19 AM To: Xie Shaohui-B21989 Cc: Wood Scott-B07421; u-boot@lists.denx.de; Tabi Timur-B04825 Subject: Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.
On 06/05/2012 09:45 PM, Xie Shaohui-B21989 wrote:
-----Original Message----- From: Wood Scott-B07421 Sent: Wednesday, June 06, 2012 2:14 AM To: Xie Shaohui-B21989 Cc: Wood Scott-B07421; u-boot@lists.denx.de; Tabi Timur-B04825 Subject: Re: [U-Boot] [PATCH] powerpc/CoreNet: add tool to support pbl image build.
On 06/05/2012 12:35 AM, Xie Shaohui-B21989 wrote:
+++ b/board/freescale/corenet_ds/config.mk @@ -0,0 +1,26 @@ +#
+#PBL preamble and RCW header +aa55aa55 010e0100 +#64 bytes RCW data for P4080, replace it when building image #for +P3041DS or P5020DS. +4c580000 00000000 18185218 0000cccc 40464000 3c3c2000 58000000 +61000000 00000000 00000000 00000000 008b6000 00000000 00000000 +00000000 00000000
Could you have the tool source this from a separate file, rather than require the user to replace it manually?
[Xie Shaohui] Then I have to prepare a separate file and a tool... It is quite simple to replace, just copy and paste, and users may need to modify the RCW when the default one does not fit their use case, they will always have to do it manually. It's simple to do it
here.
I disagree that copy and paste is good enough, though taking an external RCW source (such as output from Timur's tool) could be a future enhancement.
[Xie Shaohui] OK. Suppose we got the output from Timur's tool, what should we do for the input if we need to change the RCW?
You change the input to Timur's tool -- that's what it's for. It compiles a textual description of the RCW settings into a PBL image.
Can Timur's tool do it automatically, or by some arguments provided? And even though, there will be two files for configuration, one is RCW output from Timur's tool, and another is PBI commands. This is too much for the tool; it has only one entry for configuration file.
Too much for which tool, and why can't that be changed?
[Xie Shaohui] The mkimage structure provides one entry to indicate the configuration file, is it OK to add a more entry just for PBL?
Talk to Timur (when he gets back from vacation in a couple weeks) about his RCW tool and how best to accept the output it produces.
Why is eSPI in here? Isn't this supposed to just generically write an image into CPC SRAM?
[Xie Shaohui] No. some interfaces need to be pre-initialized before PBL start to load stuff from it, and default configurations for SPI is suitable, this tool provides a more compatible configurations.
What do you mean by a more compatible configuration? If the default is good enough to load the first few PBL commands, why is it not goot enough to load the rest?
[Xie Shaohui] the default configurations for SPI is too slow, it will take more than half minutes to finish the loading.
Please add a comment describing what you're doing to the SPI controller and why. Are there any situations where the faster speed you're programming won't work?
[Xie Shaohui] OK. Will add a comment in new version. The configuration for SPI is same as the one used in u-boot, so I think it's OK for PBL.
Best Regards, Shaohui Xie