Dear Giulio Benetti,
In message h1dlfe$3bu$1@ger.gmane.org you wrote:
Based on at91sam9263. It is a thermostimulator for hair styling. Subsection of Software is based on at91sam9263ek one.
Signed-off-by: giulio.benetti@micronovasrl.com
Please use git-format-patch to prepare patches.
Entries for MAINTAINERS and MAKEALL files are missing.
Please use TABs (instead of spaces) for vertical alignment.
diff -urpN b/board/micronova/c5000/c5000.c a/board/micronova/c5000/c5000.c --- b/board/micronova/c5000/c5000.c 1970-01-01 01:00:00.000000000 +0100 +++ a/board/micronova/c5000/c5000.c 2009-06-18 12:57:52.000000000 +0200
...
at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9263_ID_LCDC);gd->fb_base = PHYS_SDRAM + 0x3FB5000; /* mapped into sdram @ 0x20000000 +(64 MByte - (640x480) 8bpp) */
Line too long. Please fix globally.
+int dram_init(void) +{
gd->bd->bi_dram[0].start = PHYS_SDRAM;gd->bd->bi_dram[0].size = PHYS_SDRAM_SIZE;return 0;+}
How about using get_ram_size() for auto-sizing and memory testing?
diff -urpN b/board/micronova/c5000/config.mk a/board/micronova/c5000/config.mk --- b/board/micronova/c5000/config.mk 1970-01-01 01:00:00.000000000 +0100 +++ a/board/micronova/c5000/config.mk 2009-06-18 12:55:19.000000000 +0200 @@ -0,0 +1 @@ +TEXT_BASE = 0x23f00000
Copyright entry missing.
diff -urpN b/Makefile a/Makefile --- b/Makefile 2009-06-14 21:30:39.000000000 +0200 +++ a/Makefile 2009-06-18 12:55:19.000000000 +0200 @@ -2752,6 +2752,9 @@ at91sam9rlek_config : unconfig pm9263_config : unconfig @$(MKCONFIG) $(@:_config=) arm arm926ejs pm9263 ronetix at91
+c5000_config : unconfig
@$(MKCONFIG) $(@:_config=) arm arm926ejs c5000 micronova at91
Please keep lists sorted.
Best regards,
Wolfgang Denk