-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Monday, June 28, 2010 5:32 PM To: Tor Krill Cc: Prafulla Wadaskar; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.
Dear Tor Krill,
In message 1277716302.2221.37.camel@tor-desktop you wrote:
- For the boards using single port will also need to
configure PHY address
for other port, which is meaningless, unnecessary and confusing.
Sure you had to put something there to be on the safe side.
But is that
really that confusing, the SOC really have two ports, them
being used or
not?
It is indeed confusing and should be avoided if one has to configurwe hardware ports that are not actually present or used on a specific board.
If needed, provide sane defaults internally in the code.
But keep in mind that U-Boot requires that only used peripherals should be initialized - we should not initisalize any unused ports.
Yes, This is already taken care by kirkwood_egiga driver, it only initialize selected port
Regards.. Prafulla . .