Hi,
On Mon, 2018-03-26 at 13:09 +0200, Maxime Ripard wrote:
Hi,
On Sun, Mar 25, 2018 at 02:35:59PM +0200, Paul Kocialkowski wrote:
This introduces a newer dts for the Ainol AW1, that will be the base for introducing upstream Linux support for the device.
This update in U-Boot allows fixing USB OTG detection, that was missing from the previous dts.
Signed-off-by: Paul Kocialkowski contact@paulk.fr
We usually will use the Linux DTS once it's been merged, so please send it there first.
Sure thing!
[...]
Your nodes should be ordered by alphabetical order (at least as much as possible, this isn't really doable for all the AXP stuff).
I tried to preserve the order from the sun7i-a20.dtsi file, which felt like the most straightforward thing to do.
Is there any particlar reason why things should be sorted alphabetically? It feels like it has the potential to explode related blocs in different areas of the file, thus reducing readability (like you've mentioned for the AXP).
+&pio {
- backlight_enable_pin: backlight_enable_pin@0 {
pins = "PH7";function = "gpio_out";- };
- usb0_id_detect_pin: usb0_id_detect_pin@0 {
pins = "PH4";function = "gpio_in";bias-pull-up;- };
- usb0_vbus_pin: usb0_vbus_pin@0 {
pins = "PB9";function = "gpio_out";- };
+};
We're trying to remove these nodes from our DTs, it's redundant since the GPIOs will request the pin in pinctrl when being taken.
+&pwm {
- pinctrl-names = "default";
- pinctrl-0 = <&pwm0_pins_a>;
- status = "okay";
+};
+&lradc {
- vref-supply = <®_vcc3v0>;
- status = "okay";
- button@571 {
label = "Volume Up";linux,code = <KEY_VOLUMEUP>;channel = <0>;voltage = <571428>;- };
- button@761 {
label = "Volume Down";linux,code = <KEY_VOLUMEDOWN>;channel = <0>;voltage = <761904>;- };
- button@952 {
label = "Home";linux,code = <KEY_HOME>;channel = <0>;voltage = <952380>;- };
};
&uart0 { @@ -27,3 +177,60 @@ pinctrl-0 = <&uart0_pins_a>; status = "okay"; };
+&i2c0 {
- pinctrl-names = "default";
- pinctrl-0 = <&i2c0_pins_a>;
- status = "okay";
- axp209: pmic@34 {
reg = <0x34>;interrupt-parent = <&nmi_intc>;interrupts = <0 IRQ_TYPE_LEVEL_LOW>;- };
+};
+#include "axp209.dtsi"
+®_dcdc2 {
- regulator-always-on;
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1450000>;
- regulator-name = "vdd-cpu";
+};
+®_dcdc3 {
- regulator-always-on;
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1400000>;
- regulator-name = "vdd-int-dll";
+};
+®_ldo1 {
- regulator-name = "vdd-rtc";
+};
+®_ldo2 {
- regulator-always-on;
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <3000000>;
- regulator-name = "avcc";
+};
+®_usb0_vbus {
- pinctrl-0 = <&usb0_vbus_pin>;
- gpio = <&pio 1 9 GPIO_ACTIVE_HIGH>; /*PB9 */
- status = "okay";
+};
+®_usb1_vbus {
- status = "okay";
+};
+®_usb2_vbus {
- status = "okay";
+};
+&usb_power_supply {
- status = "okay";
+};
2.16.2