On Thu, 2018-10-11 at 10:10 -0400, Tom Rini wrote:
On Tue, Oct 09, 2018 at 11:54:04AM +0800, Ryder Lee wrote:
This adds a general board file based on MT7629 SoCs from MediaTek.
Apart from the generic parts (cpu) we add some low level init codes and initialize the early clocks.
Signed-off-by: Ryder Lee ryder.lee@mediatek.com Signed-off-by: Weijie Gao weijie.gao@mediatek.com
[snip]
diff --git a/include/configs/mt7629.h b/include/configs/mt7629.h new file mode 100644 index 0000000..e640108 --- /dev/null +++ b/include/configs/mt7629.h @@ -0,0 +1,71 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/*
- Configuration for MediaTek MT7629 SoC
- Copyright (C) 2018 MediaTek Inc.
- Author: Ryder Lee ryder.lee@mediatek.com
- */
+#ifndef __MT7629_H +#define __MT7629_H
+#include <linux/sizes.h>
+#include <dt-bindings/clock/mt7629-clk.h> +#include <dt-bindings/power/mt7629-power.h>
We don't want these two includes here.
+#ifndef __ASSEMBLY__ +extern unsigned long get_spl_size(void); +#endif
Nor should we have this here.
+/* Machine ID */ +#define CONFIG_MACH_TYPE 7629
Since this is for pre-DT kernels, lets drop this.
+#define NOR_MMAP_ADDR 0x30000000 +#define CONFIG_SYS_SPI_U_BOOT_OFFS get_spl_size() +#define CONFIG_SYS_UBOOT_BASE (NOR_MMAP_ADDR + get_spl_size())
Use the value of NOR_MMAP_ADDR directly, and we use some constant (rounded up as needed) for SYS_SPI_U_BOOT_OFFS not a function.
And all of these comments apply to the other include/configs/ files in the rest of the series too, thanks!
Okay. I've sent a new series to fix these.