1 May
2016
1 May
'16
9:35 p.m.
Hi Andreas,
On 30 April 2016 at 19:01, Andreas Bießmann andreas.devel@googlemail.com wrote:
The getopt(3) optstring '-' is a GNU extension which is not available on BSD systems like OS X.
Remove this dependency by implementing argument parsing in another way. This will also change the lately introduced '-b' switch behaviour.
Signed-off-by: Andreas Bießmann andreas.devel@googlemail.com
Makefile | 2 +- doc/mkimage.1 | 6 +++--- tools/mkimage.c | 33 ++++++++++++--------------------- 3 files changed, 16 insertions(+), 25 deletions(-)
This looks good to me and the code is cleaner but I'm a bit worried about the -b flag change. It makes it impossible to do something like
mkimage ... -b *.dtb output.fit
Perhaps this is a small price to pay?
Reviewed-by: Simon Glass sjg@chromium.org
Regards, Simon