Hi Grant,
On 03/28/2011 03:58 PM, Grant Likely wrote:
From: Grant Likelygrant.likely@linaro.org
For the calls to boot_relocate_fdt(), boot_get_cmdline(), and boot_get_kbd(), the value of bootmem_base is always obtained by calling getenv_bootm_low(). Since the value always comes from the same source, the calling signature for those functions can be simplified by making them call getenv_bootm_low() directly.
Signed-off-by: Grant Likelygrant.likely@linaro.org
[snip]
diff --git a/include/image.h b/include/image.h index 005e0d2..aa1d7df 100644 --- a/include/image.h +++ b/include/image.h
[snip]
@@ -345,11 +344,10 @@ int boot_ramdisk_high (struct lmb *lmb, ulong rd_data, ulong rd_len, ulong *initrd_start, ulong *initrd_end); #endif /* CONFIG_SYS_BOOT_RAMDISK_HIGH */ #ifdef CONFIG_SYS_BOOT_GET_CMDLINE -int boot_get_cmdline (struct lmb *lmb, ulong *cmd_start, ulong *cmd_end,
ulong bootmap_base);+int boot_get_cmdline (struct lmb *lmb, ulong *cmd_start, ulong *cmd_end)
___________________________________________________________________________^
D'oh, you lost a semicolon. Compiles for ARM, not so well for PowerPC. Took me a bit of staring and head scratching to see the missing piece (the hardest thing to see is the thing that isn't there).
I'm having a problem with patch 2 of 6 as well, getenv_bootm_base() not found for PowerPC, apparently the code isn't used in ARM.
Thanks, gvb