Hi,
On 29-12-14 14:50, Ian Campbell wrote:
On Wed, 2014-12-24 at 20:06 +0100, Hans de Goede wrote:
You've got three p's in suppport in the subject.
Some SoCs, specifically the A13 (sun5i variant) and the A23 (sun8i) only have lcd output support.
Signed-off-by: Hans de Goede hdegoede@redhat.com
board/sunxi/Kconfig | 7 +++++++ drivers/video/sunxi_display.c | 30 ++++++++++++++++++++++++++---- 2 files changed, 33 insertions(+), 4 deletions(-)
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig index 35c59e9..7a8503b 100644 --- a/board/sunxi/Kconfig +++ b/board/sunxi/Kconfig @@ -246,6 +246,13 @@ config VIDEO or VGA output found on most sunxi devices. See doc/README.video for info on how to select the video output and mode.
+config VIDEO_HDMI
- boolean "HDMI output support"
- depends on VIDEO && !MACH_SUN8I
There is no "&& !MACH_SUN5I" here because there are sun5i variants other than the A13 which do have HDMI, correct?
Correct, the A10s has HDMI out support.
@@ -278,7 +282,7 @@ static void sunxi_composer_init(void) (struct sunxi_de_be_reg *)SUNXI_DE_BE0_BASE; int i;
-#ifdef CONFIG_MACH_SUN6I +#if defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I
These seem a bit odd. If the sun8i has no HDMI why are we messing with the reset bits? (Or at least, why is such messing new in this particular patch).
I think perhaps rather than "disabling the non-existent HDMI on sun8i" which is how I read the patch description I should have read "enable video on sun8i, which supports LCD but not HDMI"?
Yeah that is better, I'll do a v2 with the commit message fixed.
Regards,
Hans