Hi,
On 03/22/2014 07:52 AM, Wolfgang Denk wrote:
Dear Ian Campbell,
In message 1395438866-1193-4-git-send-email-ijc@hellion.org.uk you wrote:
This has been stripped back for mainlining and supports only sun7i. These changes are not useful by themselves but are split out to make the patch sizes more manageable.
As well as the following signed-off-by the sunxi branch shows commits to these files authored by the following: Almo Nito Carl van Schaik FUKAUMI Naoki hehopmajieh j Sergey Lapin Tom Cubie
Sorry, this is a NAK for these patches.
"These changes are not useful by themselves but are split out to make the patch sizes more manageable." This is not how we work. Patches have to implement specific features, or fix specific bugs. And they have to maintain bisectability of the code.
These patches do implement specific features, like dram init, timer/clk init, etc. They just don't enable them yet as by themselves they are not useful.
The patches also maintain bisectability since they don't touch any existing files until the patch 5 and 6 come into play, and the changes in patch 5 keep things compiling just fine.
FWIW I believe the split-up Ian has done makes sense. But if you insist I guess we can merge patch 1-6 (the minimum set to get something working) into 1 big patch.
Regards,
Hans