Hi Dirk,
On Wednesday 13 October 2010 14:19:19 Eibach, Dirk wrote:
Why not use the already available GPIO functions instead (gpio_write_bit() etc)? This will make it easier to move this to the common (Linux) GPIO API at some time later.
Hmm, nice, didn't notice those yet. But somehow functionality is missing for toggling between output and tristate mode without changing output value. In linux we have gpio_direction_input() and gpio_direction_output() for this purpose.
Should I add something like this to ppc4xx-gpio.h?
Best would be to move to the Linux GPIO API for PPC4xx in U-Boot now then. This has been discussed before on the list. And is on my list of open tasks. But it will have to wait a few more weeks I'm afraid. Perhaps you have some spare cycles left to migrate the current GPIO API to the Linux one? See Blackfin arch as an example.
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de