Hi Lukasz,
On Sat, 18 May 2019 at 14:52, Lukasz Majewski lukma@denx.de wrote:
On Sat, 18 May 2019 10:08:36 -0600 Simon Glass sjg@chromium.org wrote:
On Thu, 16 May 2019 at 16:11, Lukasz Majewski lukma@denx.de wrote:
This commit adds the clk_get_parent() function, which is responsible for getting the parent's struct clock pointer.
U-boot's DM support for getting parent is different (the parent relationship is in udevice) than the one in common clock framework (CCF) in Linux. To obtain the pointer to struct clk of parent the pdev->driver_data field is read.
Signed-off-by: Lukasz Majewski lukma@denx.de
Changes in v4: None Changes in v3:
- New patch
drivers/clk/clk-uclass.c | 15 +++++++++++++++ include/clk.h | 9 +++++++++ 2 files changed, 24 insertions(+)
Please can you add a test for this?
It is implicitly covered here: http://patchwork.ozlabs.org/patch/1100767/
but maybe shall I add a separate test case?
That's fine I think. We just want to make sure that if someone breaks the code we will notice.
However, considering the other reply to the driver_data field usage, those tests would probably need redesign anyway.
Yes I really am not keen on that.
Regards, Simon