Prafulla Wadaskar wrote:
-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Remy Bohmer Sent: Wednesday, July 08, 2009 12:16 AM To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Hello All,
2009/7/4 Michael Trimarchi trimarchi@gandalf.sssup.it:
Jean-Christophe PLAGNIOL-VILLARD wrote:
On 20:56 Mon 29 Jun , Prafulla Wadaskar wrote:
Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
drivers/usb/host/ehci-hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Remy could you look the marvell usb patch?
I think that this one is correct but not yet tested
Sorry for not being very responsive these days... it is vacation time... ;-)
This patch of Michael looks good, and I prefer that patch above the marvell usb patch.
Patch by me ;-D
If anybody of you are able of testing it, I can apply it. (I do not have the proper hardware myself)
Hi Kumar I have seen a patch by you to this file Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html I hope you have h/w and tested ehci-hcd driver :-) Can you pls comment on this? FYI: I have tested it for Sheevaplug Kirkwood hardware If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)
I wonder why it has not been detected on any other platforms yet! Any one ...Any comments ??
Because there was an error in the switch :( maybe, that I fix in my patch, but I can't test now because I don't have any hardware.
- typeReq = req->request << 8 | req->requesttype; + typeReq = req->request | req->requesttype << 8;
- switch (le16_to_cpu(typeReq)) { + switch (typeReq) {
Michael
Regards.. Prafulla . .
Kind Regards,
Remy _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot