Re: [U-Boot-Users] [PATCH] Where does U-Boot's CFI driver check for top/bottom boot?

timur@freescale.com wrote:

From: Timur Tabi timur@freescale.com

This patch adds support for the reversed geometry data in some AMD flash chips.

I'm not proud of this patch, so I'm posting it for review only. I know it works on the my board that was the problem, but I have no idea if it will break any other board. I'm sure this code could be improved a lot.

NAK. It will break any bottom boot AMD flash. I have reviewed Linux MTD driver and the coder had nice things to say about AMD regarding this matter (!).

Anyway, I will get proper patch to you to try tonight or tomorrow. I do not have a board with AMD flash myself.

Tolunay