Hi Maxime,
Dne ponedeljek, 24. april 2017 ob 09:19:40 CEST je Maxime Ripard napisal(a):
Hi Jernej,
On Fri, Apr 21, 2017 at 07:24:12PM +0200, Jernej Škrabec wrote:
Dne petek, 21. april 2017 ob 09:04:13 CEST je Maxime Ripard napisal(a):
Hi Jernej,
On Mon, Mar 27, 2017 at 07:22:28PM +0200, Jernej Skrabec wrote:
This series implements support for HDMI output. This is done using DM video framework and sharing the HDMI controller code with RK3288.
Patch 1 splits out TCON code which is completely reusable on all Allwinner SoCs.
Patch 2 converts common TCON code to use DM video compatible timing structure.
Patch 3 adds all necessary clocks which are needed for Display Engine 2, TCON and HDMI.
I merged all these patches...
Patch 4 implement actual DE2 and HDMI driver and patch 5 disables HDMI on all boards which don't have it (default is on).
But not this one, since it creates a Kconfig warning due to the dependency of I2C_EDID on DM_I2C.
I think the current state of this discussion is that the i2c driver should be converted to the DM, which seems to be stalled at the moment.
Could you take in that patch and do the minor rework that were suggested by Simon so that we can get this in ?
Sorry I missed what was suggested by Simon?
Yes, of course. Should I also simplify the driver, because since then I learned a bit more about DE2? Or should I sent follow up patch?
Which driver are you talking about? DE's or the i2c driver?
DE
If it is something that was already merged, it's better if you send follow up patches. If it's a patch that is still pending, then you can do it in that patch and resend a new version.
Ok, I will send a new version.
Regards, Jernej