Hi,
On 20 February 2015 at 10:54, Stephen Warren swarren@wwwdotorg.org wrote:
On 02/20/2015 10:06 AM, Simon Glass wrote:
+Stephen
Hi Masahiro,
On 19 February 2015 at 22:25, Masahiro Yamada yamada.m@jp.panasonic.com wrote:
Now CONFIG_SPL_BUILD is not defined in Kconfig, so "!depends on SPL_BUILD" and "if !SPL_BUILD" are redundant.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 41f3220..700e2a8 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -739,9 +739,8 @@ config TEGRA bool "NVIDIA Tegra" select SUPPORT_SPL select SPL
select OF_CONTROL if !SPL_BUILDselect CPU_ARM720T if SPL_BUILDselect CPU_V7 if !SPL_BUILD
select OF_CONTROLselect CPU_V7Sorry if I have missed something here. On Tegra most unfortunately the SPL uses ARMv4t and U-Boot proper uses ARMv7. In fact that is the only reason that Tegra has SPL. Doesn't this change with this commit?
Yes, on Tegra SPL runs on an ARMv4t and main U-Boot on some ARMv7 CPU. The change above is actively incorrect.
The OF_CONTROL change is probably incorrect too; we certainly don't intend to use OF_CONTROL in the SPL (there's really nothing to control in the SPL)
- I just don't know if enabling that feature will cause any issue. Things to
look out for would be bloat of the SPL binary so that it didn't fit into the space before the main binary's TEXT_BASE, since the two get concatenated together into a single binary that's loaded into RAM, and XIP'd.
This at least is not a problem with this patch.
I'll make some time to take a look at this in the next few days.
Regards, Simon