-----Original Message----- From: Simon Kagstrom [mailto:simon.kagstrom@netinsight.net] Sent: Monday, November 23, 2009 1:04 PM To: Wolfgang Denk Cc: Ben Warren; U-Boot ML; Prafulla Wadaskar Subject: Re: [U-Boot] [RFC/PATCH 1/2]: Arm: Kirkwood: Split PHY-related initialization to a common file
On Sun, 22 Nov 2009 21:57:05 +0100 Wolfgang Denk wd@denx.de wrote:
In message 20090713131125.6e6a3e33@marrow.netinsight.se
Simon Kagstrom wrote:
The mv881116 PHY initialization is split out to a
common file to enable
code reuse between different boards.
Signed-off-by: Simon Kagstrom simon.kagstrom@netinsight.net
board/Marvell/sheevaplug/sheevaplug.c | 32 +-------------- board/Marvell/sheevaplug/sheevaplug.h | 8 ---- drivers/net/phy/Makefile | 1 + drivers/net/phy/mv88e1116.c | 66
+++++++++++++++++++++++++++++++++
include/configs/sheevaplug.h | 1 + include/mv88e1116.h | 29 ++++++++++++++ 6 files changed, 100 insertions(+), 37 deletions(-) create mode 100644 drivers/net/phy/mv88e1116.c create mode 100644 include/mv88e1116.h
Ping...
Can you please check the status of this patch:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/63590/f ocus=63591
I believe Prafulla voted to keep the PHY stuff locally in sheevaplug.c and openrd_base.c until the generic PHY support was added. So I later submitted a patch with the PHY init for OpenRD base in the board-file (like sheevaplug).
So I think this patch should simply be dropped - code reuse will happen in a more generic way later anyway. Perhaps you have some additional comments, Prafulla?
I think we should port it in generic way, because there are numerous board in pipeline which will have to use similar support and there will be code duplication.
If I remember correctly, Jean has also put some efforts in this direction. This is call for Ben
Hi Ben and Jean Is Generic PHY arch is ready to use (even though in bits and patches)? Can we start migrating Marvell Switch/PHY devices for the same?
Regards.. Prafulla . .
// Simon