Re: [U-Boot] [PATCH 02/22] sandbox: Correct device tree 'reg' properties for I2C and SPI

Hi Simon,

On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass sjg@chromium.org wrote:

These are missing a size value. Add one in each case.

Signed-off-by: Simon Glass sjg@chromium.org

arch/sandbox/dts/sandbox.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts index 9ce31bf..1ccfdee 100644 --- a/arch/sandbox/dts/sandbox.dts +++ b/arch/sandbox/dts/sandbox.dts @@ -144,7 +144,7 @@ i2c@0 { #address-cells = <1>; #size-cells = <0>;

•           reg = <0>;
  

•           reg = <0 0>;
  

Why? Its parent node's #size-cells is 0.

            compatible = "sandbox,i2c";
            clock-frequency = <400000>;
            eeprom@2c {

@@ -161,7 +161,7 @@ spi@0 { #address-cells = <1>; #size-cells = <0>;

•           reg = <0>;
  

•           reg = <0 0>;
            compatible = "sandbox,spi";
            cs-gpios = <0>, <&gpio_a 0>;
            flash@0 {
  

--

Regards, Bin