Re: [U-Boot] [PATCH 04/10] mxc_nand: add nand driver for MX2/MX3

Dear Ilya,

In message 1241634633-13917-5-git-send-email-yanok@emcraft.com you wrote:

Driver for NFC NAND controller found on Freescale's MX2 and MX3 processors. Ported from Linux. Tested only with i.MX27 but should works with other MX2 and MX3 processors too.

...

+/* Set INT to 0, FCMD to 1, rest to 0 in NFC_CONFIG2 Register

• • for Command operation */

Incorrect multiline comment style. Here and elsewhere.

...

+static void send_prog_page(struct mxc_nand_host *host, uint8_t buf_id,

• 	int spare_only)
  

+{

• MTDDEBUG(MTD_DEBUG_LEVEL3, "send_prog_page (%d)\n", spare_only);
• /* NANDFC buffer 0 is used for page read/write */
• writew(buf_id, host->regs + NFC_BUF_ADDR);
• /* Configure spare or page+spare access */
• if (!host->pagesize_2k) {

• uint16_t config1 = readw(host->regs + NFC_CONFIG1);
  

• if (spare_only)
  

• 	config1 |= NFC_SP_EN;
  

• else
  

• 	config1 &= ~(NFC_SP_EN);
  

Use setbits*() / clrbits*() ? Here and elsewhere.

Best regards,

Wolfgang Denk