Hi Akshay,
On 21 May 2014 23:32, Akshay Saraswat akshay.s@samsung.com wrote:
Passing fewer arguments is better and mem_iv_size is never used. Let's keep only one argument and make it cleaner.
I agree with removing mem_iv_size as it is not used. But all you are doing with the other parameter is making the called function look it up again. I'm not sure that is a win. It doesn't reduce code size. (see commit 05 - there is no change).
./tools/buildman/buildman -b try-pit smdk5420 -sS Summary of 8 commits for 2 boards (2 threads, 2 jobs per thread) 01: ARM: exynos5420: removed undefined gpio structure arm: + peach-pit 02: Exynos5420: Introduce support for the Peach-Pit board 03: Exynos5420: Let macros be used for exynos5420 arm: peach-pit 04: Exynos: Make sure ps_hold gets set in the SPL arm: (for 2/2 boards) spl/u-boot-spl:all +72.0 spl/u-boot-spl:text +72.0 05: Exynos5: DMC: Modify the definition of ddr3_mem_ctrl_init 06: Exynos5420: Remove code for enabling read leveling arm: (for 2/2 boards) spl/u-boot-spl:all -344.0 spl/u-boot-spl:text -344.0 07: DMC: exynos5420: Gate CLKM to when reading PHY_CON13 arm: (for 2/2 boards) spl/u-boot-spl:all +136.0 spl/u-boot-spl:text +136.0 08: Exynos5420: DMC: Add software read leveling arm: (for 2/2 boards) spl/u-boot-spl:all +712.0 spl/u-boot-spl:rodata +16.0 spl/u-boot-spl:text +696.0 (try-pit=9276cf: b/ fred.dtb mdk5420 sandbox/ scripts/ x) ~/u>
Anyway it doesn't hurt, so:
Acked-by: Simon Glass sjg@chromium.org
Signed-off-by: Hatim Ali hatim.rv@samsung.com Signed-off-by: Akshay Saraswat akshay.s@samsung.com
Regards, Simon