-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Wednesday, June 08, 2011 13:31 PM To: Zang Roy-R61911 Cc: u-boot@lists.denx.de; Xu Lei-B33228; Kumar Gala; Wang Haiying-R54964; sun york-R58495; Lan Chunhe-B25806 Subject: Re: [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board
Dear Roy Zang,
In message 1307508687-12522-1-git-send-email-tie-fei.zang@freescale.com you wrote:
The P1023RDS board is the reference board for the P1023 SoC.
Add support for booting it from NOR or NAND, with fixed 2G of DDR, PCIe, UART, I2C, etc.
Please fix the checkpatch warnings (7 lines over 80 characters)
I can fix it. In fact, I use checkpatch every time before I send out patch. If you check the board header file, most of them has this problem.
Do you think + /* physical addr of CCSRBAR */ +#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR is better than +#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR /* physical addr of CCSRBAR */ ??? Please clarify.
...
+/* ECC will be enabled based on perf_mode environment variable */ +#undef CONFIG_DDR_ECC
...
+#undef CONFIG_CLOCKS_IN_MHZ
...
+#undef CONFIG_SYS_RAMBOOT
...
+#undef CONFIG_SERIAL_SOFTWARE_FIFO
...
+#undef CONFIG_SOFT_I2C /* I2C bit-banged */
...
+#undef CONFIG_WATCHDOG /* watchdog disabled */
...
+#undef CONFIG_BOOTARGS /* the boot command will set bootargs
*/
etc. Please do not undef what is not defined in the first place.
Will fix. Thanks. Roy
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Real Programmers always confuse Christmas and Halloween because OCT 31 == DEC 25 ! - Andrew Rutherford (andrewr@ucs.adelaide.edu.au)