Hi Simon,
On Tue, May 21, 2019 at 10:43:04AM -0600, Simon Glass wrote:
On Mon, 20 May 2019 at 01:23, Eugeniu Rosca erosca@de.adit-jv.com wrote:
[..]
I can identify two Android-dedicated README files, but none of them seems to be suitable for the new command:
- doc/README.android-fastboot
- doc/README.avb2
Igor, Sam, what's your view on the above? Would you suggest creating a doc/README.android-bcb or there is a more elegant solution to it?
How about a new README.android which links to the other two and adds your new info?
How about below directory structure:
u-boot $ tree doc/android doc/android ├── avb2.txt ├── bcb.txt └── fastboot.txt
Should it default to enabled if avb is used?
I think at this specific moment in time, 'bcb' is orthogonal (meaning it is neither a direct, nor a reverse dependency) to any other Android feature in U-Boot. This could be re-assessed, if platform maintainers start to rely on 'bcb' in their U-Boot environments on regular basis.
OK. Also is there a sandbox driver for this? We should have a test.
Emulating and exposing MMC devices in sandbox should be the only prerequisite for sandbox testing and this seems to be already supported via drivers/mmc/sandbox_mmc.c. However, to be honest, I was unsuccessful bringing up the MMC devices on sandbox in the past. Particularly, booting the latest sandbox U-Boot (CMD_MMC=y) I get:
=> mmc list No MMC device available
I think there is something elementary which I am missing?
Regardless, I need some more days to implement the test and repartition the README files. I think Sam would appreciate if you can provide your Ack to the series as-is (it was extensively statically and dynamically tested on R-Car H3ULCB) and I submit the doc/test updates separately. Otherwise, I will push the next revision hopefully in a week or so.
Regards, Simon