-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/24/2013 12:45 PM, Simon Glass wrote:
Hi Tom,
On Mon, Feb 18, 2013 at 2:08 PM, Tom Rini trini@ti.com wrote:
On Wed, Dec 26, 2012 at 10:57:05AM -0800, Simon Glass wrote:
Use setenv_ulong(), setenv_hex() and setenv_addr() in common/
Signed-off-by: Simon Glass sjg@chromium.org
[snip]
diff --git a/common/cmd_fdos.c b/common/cmd_fdos.c index fbee861..5a35cc1 100644 --- a/common/cmd_fdos.c +++ b/common/cmd_fdos.c
[snip]
@@ -91,8 +90,7 @@ int do_fdosboot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) } flush_cache (load_addr, size);
- sprintf(buf, "%x", size); - setenv("filesize", buf); +
setenv_hex("filesize", size);
Tab and space mixing in the function. I'll fix if git am --whitespace=fix doesn't spot and fix.
I'll change it back to spaces so that it is consistent, even if checkpatch is upset. There are now 5 patches changed so I will send out the whole series again.
Right, we should always be consistent with the file. From my read of the series, this was the only one where the file used spaces and the new insert was tabs, that's what I'm getting at. I guess the others didn't stick out as obviously?
- -- Tom