Re: [PATCH] Makefile: doesn't need check stack size when dtb is not built

On 3/3/20 11:54 PM, AKASHI Takahiro wrote:

The commit 5fed97af20da ("Makefile: ensure DTB doesn't overflow into initial stack") adds an extra check for stack size in BSS if CONFIG_SYS_INIT_SP_BSS_OFFSET is enabled. This check, however, doesn't make sense under the configuration where control dtb won't be built in and it should be void in such cases.

Don't you want to edit the following hunk from the original patch instead or as well?

+ifneq ($(CONFIG_SYS_INIT_SP_BSS_OFFSET),) +ALL-y += init_sp_bss_offset_check +endif

That's why there's no rule for init_sp_bss_offset_check in the else case.