Hi Marek
From: Marek Vasut marex@denx.de Sent: jeudi 23 janvier 2020 23:45
On 1/23/20 10:57 AM, Patrick DELAUNAY wrote:
Hi Marek,
Hi,
From: Marek Vasut marex@denx.de Sent: mardi 21 janvier 2020 22:39
Add support for DH Electronics DHCOM SoM and PDK2 rev. 400 carrier board. This is an SoM with STM32MP157C and an evaluation kit. The baseboard provides Ethernet, UART, USB, CAN and optional display.
Signed-off-by: Marek Vasut marex@denx.de Cc: Patrick Delaunay patrick.delaunay@st.com Cc: Patrice Chotard patrice.chotard@st.com
Few remarks (see after) about 1/ name of dts file (I prefer to don't add a file "-u-boot.dts") 2/ stusb1600 support (it seens that the PDK2 board hav no this USB type C controller, so part of code can be dropped) 3/ ST board specific part are not needed : OTP_BOARD / command stboard
But anayway:
Reviewed-by: Patrick Delaunay patrick.delaunay@st.com
I propose something for the first point on the custodians git, branch "dh" https://gitlab.denx.de/u-boot/custodians/u-boot-stm.git
see " fixup! ARM: dts: stm32: Add DH Electronics DHCOM SoM and PDK2 board" on dh branch
Did you verify that the generated DT is identical for U-Boot and SPL before and after this change ?
Yes => same dtb after the patch.
(I use "dtc -I dtb -O dts" on the generated files and I compare the dts file)
Are you are ok with this proposal ?
In the same branch I propose 2 other modifications to reduce the size of board.c (remove feature note needed).
- remove stusb1600 support
- remove OTP_BOARD support and cmd_stboard
These two are OK, thanks.
You send a V3 ?
I can squash the 3 commit on the branch And I merge it like that.... Regards
-- Best regards, Marek Vasut
Patrick