Hi Vasily,
On Fri, Jun 21, 2019 at 5:58 AM Vasily Khoruzhick anarsoul@gmail.com wrote:
On Mon, Jun 17, 2019 at 12:37 AM Jagan Teki jagan@amarulasolutions.com wrote:
This is the v2 set for supporting LPDDR4 with associated features, wrt to previous series[1].
Thanks to
- YouMin Chen
- Akash Gajjar
- Kever Yang
for supporting all the help on this work.
On summary this series support
- Code warning and fixes
- rank detection, this would required to probe single channel sdram configured in NanoPI-NEO4
- LPDDR4 support, tested in Rockpro64 and Rock-PI-4
Changes for v2:
- handle LPDDR4 code as part of CONFIG_RAM_RK3399_LPDDR4
- support data_training and set_rate via sdram_rk3399_ops
- add proper sys_reg_enc macros
- add new patch to rename variable sdram_params with params
- fix few commit messages
patch 0001 - 0034: fix code warnings, prints, new macros
patch 0035 - 0052: rank detection, sdram debug code
patch 0053: use DDR3-1800 on NanoPI-NEO4
patch 0054 - 0094: lpddr4 support
patch 0095: enable lpddr4 in Rockpro64
patch 0096: enable lpddr4 in Rock-PI-4
patch 0097: LPDDR4-100 timings
patch 0098: Use LPDDR4-100 on Rockpro64
patch 0099: Use LPDDR4-100 on Rock-PI 4
Size (increased to ~3KiB ):
- Puma RK3399 (u-boot-spl-dtb.bin): before: 115644 after: 118744
- NanoPI M4 (u-boot-tpl-dtb.bin) before: 41873 after: 44909
Travis-CI: https://travis-ci.org/openedev/u-boot-amarula/builds/546597944
Repo: https://github.com/openedev/u-boot-amarula/tree/rk3399-lpddr4
[1] https://patchwork.ozlabs.org/cover/1113893/
Any inputs?
Was it absolutely necessary to split these changes into 99 commits? I believe at least some of them can be squashed. Reviewing 99 patches isn't feasible.
Squashed, I'm not sure because the patches were created to satisfy the bisectability and travis-ci, if you find any please feel to comment. About the commit count, I have mentioned in v1, the idea of having many commits in one series to have all lpddr4(-related) changes in one place and also all the commit has incremental approach of supporting rank detection and lpddr4. If require I'm open to sent next versions as multiple series, no problem on that.
Jagan.