26 Mar
2009
26 Mar
'09
3:39 p.m.
In message 200903261103.28452.sr@denx.de you wrote:
#define FLASH_FIXUP_ADDR_8(addr) ((void*)((ulong)(addr)^2)) #define FLASH_FIXUP_ADDR_16(addr) ((void*)((ulong)(addr)^2))
...
Yes, I think this could be accepted. The overall impact on
the driver is not
too big. Let's see if others have some complaints about it.
If not, I'll
accept you patch after you changed some minor details.
I think that should be an inline function instead of a macro.
Best regards,
Wolfgang Denk
Thanks for the comments. I will take it into account before sending the complete patch series for the board(s). But I have to do some more cleanups before I can do that.
I just wanted to check if this is the right way to go.
Best regards, Thomas Langer