On Tue, Jul 05, 2016 at 08:49:00AM -0300, Fabio Estevam wrote:
Hi Alexey,
On Tue, Jul 5, 2016 at 1:54 AM, Alexey Brodkin Alexey.Brodkin@synopsys.com wrote:
IMHO there's an obvious solution for all that - just move U-Boot's env for say another 300-400k above like that: ------------------------------>8--------------------------- diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h index 99f5c0c..e39583c 100644 --- a/include/configs/wandboard.h +++ b/include/configs/wandboard.h @@ -181,7 +181,7 @@ #define CONFIG_ENV_SIZE (8 * 1024)
#define CONFIG_ENV_IS_IN_MMC -#define CONFIG_ENV_OFFSET (6 * 64 * 1024) +#define CONFIG_ENV_OFFSET (2 * 6 * 64 * 1024) #define CONFIG_SYS_MMC_ENV_DEV 0
#endif ------------------------------>8---------------------------
Yes, please send this as a formal patch.
I fixed the same issue recently on mx6sabresd.
See commit 8fb9eea5653796 ("mx6sabre_common: Fix U-Boot corruption after 'saveenv'")
I think this shows that we need to think about fixing this in one of the more common mx6/7 header files as a "board can override" default. And maybe start thinking about moving the questions to Kconfig as well, since tbot can make sure that the conversion is correct. :)