On Thursday 24 September 2009 12:04:53 Peter Tyser wrote:
Thinking a bit more about it, we should probably choose a more generic name, so that other 4xx variants may use this command as well. How about just using "regdump"?
And please base you patch against the "4xx-register-cleanup" branch of my u- boot-ppc4xx repo.
What about adding a common 4xx_reginfo() function instead, then calling it from common/cmd_reginfo.c? Some of the 4xx dumping already in cmd_reginfo.c could also be moved to cpu/ppc4xx/[reginfo.c|cpu.c] to clean it up.
Good idea. I totally forgot about this code. At least the 4xx part is stone age and can be dropper or replaced by the new concept introduced by Niklaus.
Unless there's a good reason to have both "regdump" and "reginfo" commands...
I can't think of any. Niklaus, is this ok with you too?
If yes, then please create a patch as suggested by Peter, calling ppc4xx_reginfo() function in common/cmd_reginfo.c (analog to mpc86xx_reginfo()). And add cpu/ppc4xx/reginfo.c with this function.
I (or somebody else?) will then, if time permits, add some other 4xx variants to this ppc4xx reginfo command as well.
Cheers, Stefan
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de