Re: [U-Boot] [PATCH] unzip: return uncompressed size in `filesize', and print it.

Dear Peter Tyser,

In message 1297443439.965.1208.camel@petert you wrote:

...

• return !!gunzip((void *) dst, dst_len, (void *) src, &src_len);

• rc = gunzip((void *) dst, dst_len, (void *) src, &src_len);
• printf("Uncompressed size: %ld = 0x%lX\n", src_len, src_len);
• sprintf(buf, "%lX", src_len);
• setenv("filesize", buf);
• return !!rc;

What about: if (rc) return rc;

printf("Uncompressed size: %ld = 0x%lX\n", src_len, src_len); sprintf(buf, "%lX", src_len); setenv("filesize", buf);

return 0;

This will prevent printing and setting of bogus values when an invalid or overly large image is unzipped.

Good point, will fix. Thanks!

Best regards,

Wolfgang Denk