Re: [PATCH 2/3] ata: mvebu: use dev_read_addr() to get base address

On 04.08.20 07:14, Masahiro Yamada wrote:

It is strange to use devfdt_get_addr_ptr(), then cast the pointer back to ulong because you could use devfdt_get_addr() without casting.

Convert it to dev_read_addr(), which is capable to CONFIG_OF_LIVE.

Signed-off-by: Masahiro Yamada yamada.masahiro@socionext.com

drivers/ata/ahci_mvebu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c index 8be1826d40..7d82d2ea3f 100644 --- a/drivers/ata/ahci_mvebu.c +++ b/drivers/ata/ahci_mvebu.c @@ -39,7 +39,7 @@ static int mvebu_ahci_probe(struct udevice *dev) */ board_ahci_enable();

• ahci_probe_scsi(dev, (ulong)devfdt_get_addr_ptr(dev));

• ahci_probe_scsi(dev, dev_read_addr(dev));

Reviewed-by: Stefan Roese sr@denx.de

Thanks, Stefan