Re: [U-Boot] [PATCH] socfpga: add support for Terasic DE1-SoC board

On 11/14/2016 03:17 PM, Anatolij Gustschin wrote:

Hi,

On Mon, 14 Nov 2016 15:07:31 +0100 Marek Vasut marex@denx.de wrote: ...

...

...

+#undef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION 2

Why is this needed ? Just start U-Boot from partition 1 as all the other SoCFPGAs do , esp. since this is a devkit, please keep it consistent.

It is not really needed. I used the original Terasic SD-Card, its raw partition is 2. OK, will remove it.

Thanks!

...

Looks great otherwise :)

Thanks for review!

I'll pick V2 for the next release then. Thanks!