
Hi Mario,
On 27 April 2018 at 06:53, Mario Six mario.six@gdsys.cc wrote:
Register the IMMR region as a PCI region when PCI is used on MPC83xx.
Signed-off-by: Mario Six mario.six@gdsys.cc
v1 -> v2: No changes
drivers/pci/pci-uclass.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index a2e829608a..37ca09d76b 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -902,6 +902,11 @@ static int decode_regions(struct pci_controller *hose, ofnode parent_node, base, size, PCI_REGION_MEM | PCI_REGION_SYS_MEMORY); #endif
+#if defined(MPC83xx) && defined(CONFIG_SYS_IMMR)
pci_set_region(hose->regions + hose->region_count++,
CONFIG_SYS_IMMR, CONFIG_SYS_IMMR, 0x100000,
PCI_REGION_MEM | PCI_REGION_SYS_MEMORY);
+#endif
Please don't add device-specific code in this file. This could go in the device tree, perhaps. If not, we perhaps need to do it in your PCI driver?
return 0;
}
-- 2.16.1
Regards, Simon