Re: [U-Boot] [PATCH] fdt: Include arch specific gpio.h

On 07/10/2012 11:13 PM, Simon Glass wrote:

Hi Michal,

On Tue, Jul 10, 2012 at 11:56 AM, Michal Simek <monstr@monstr.eu mailto:monstr@monstr.eu> wrote:

Also include arch specific gpio.h which can contain
gpio function implementation.

Signed-off-by: Michal Simek <monstr@monstr.eu <mailto:monstr@monstr.eu>>
CC: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>>
---
  lib/fdtdec.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index cc09e06..b12eb77 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -25,6 +25,7 @@
  #include <fdtdec.h>

  /* we need the generic GPIO interface here */
+#include <asm/gpio.h>

Can you not instead support the generic functions? What are you missing from from there that fdtdec.c needs?

OK. The problem is with fdtdec_setup_gpio function where you called gpio_request which is gpio specific function which you haven't included.

The most archs have this defined in arch/<cpuname>/include/asm/gpio.h.

Thanks, Michal