Re: [U-Boot] [PATCH 13/16] New config variable CONFIG_PREMONITOR

On Sunday 18 December 2011 14:05:17 Mike Frysinger wrote:

On Saturday 17 December 2011 12:03:15 Pali Rohár wrote:

...

--- a/common/env_common.c +++ b/common/env_common.c

+#ifdef CONFIG_PREMONITOR

• "premonitor=" CONFIG_PREMONITOR "\0"

+#endif

--- a/common/main.c +++ b/common/main.c

+#ifdef CONFIG_PREMONITOR

• if ((s = getenv ("premonitor")) != NULL) {

i don't these should be the same define. one is to control the default env var value only. i would just drop the check in main.c.

...

+# ifndef CONFIG_SYS_HUSH_PARSER

• run_command (s, 0);
  

no space before the "(" -mike

So do you think that I should delete changes in env_common.c and add to main.c only this code?

+#ifdef CONFIG_PREMONITOR + run_command2(CONFIG_PREMONITOR, 0); +#endif