I need access to registers other than just the timekeeping ones of the pcf2127, so I wanted to implement ->read8 and ->write8. But for testing these it appeared there was no convenient way to invoke those from the shell, so I also ended up adding such a command.
Also, it seemed more natural to provide array variants that can read or write several registers at once, so rtc_ops is expanded a bit.
Changes in v2:
- Use simply "read" and "write" instead of "read8_array", "write8_array", both for functions and methods, as suggested by Simon.
- The rtc command's interface has been simplified a bit (no separate read/readm; the number of arguments determines whether the user wants the result on the console or to a memory address)
- Add tests, both of rtc_{read,write}() and of the shell command, fixing a few things I stumbled on.
Rasmus Villemoes (10): rtc: add rtc_read helper and ->read method rtc: add rtc_write() helper rtc: fall back to ->{read,write} if ->{read,write}8 are not provided rtc: pcf2127: provide ->read method rtc: pcf2127: provide ->write method rtc: add rtc command rtc: sandbox-rtc: fix set method rtc: i2c_rtc_emul: catch any write to the "reset" register test: dm: rtc: add test of rtc_read, rtc_write test: dm: rtc: add tests of rtc shell command
arch/sandbox/include/asm/rtc.h | 5 ++ cmd/Kconfig | 6 ++ cmd/Makefile | 1 + cmd/rtc.c | 159 +++++++++++++++++++++++++++++++++ drivers/rtc/i2c_rtc_emul.c | 3 +- drivers/rtc/pcf2127.c | 13 ++- drivers/rtc/rtc-uclass.c | 56 +++++++++++- drivers/rtc/sandbox_rtc.c | 65 +++++--------- include/rtc.h | 47 ++++++++++ test/dm/rtc.c | 121 ++++++++++++++++++++++++- 10 files changed, 426 insertions(+), 50 deletions(-) create mode 100644 cmd/rtc.c