On Thu, Oct 27, 2016 at 9:41 PM, Antoine Tenart antoine.tenart@free-electrons.com wrote:
Hi,
On Thu, Oct 27, 2016 at 09:21:10PM +0800, Chen-Yu Tsai wrote:
On Thu, Oct 27, 2016 at 9:10 PM, Antoine Tenart antoine.tenart@free-electrons.com wrote:
On Wed, Oct 26, 2016 at 02:38:10PM +0200, Maxime Ripard wrote:
On Wed, Oct 26, 2016 at 02:10:31PM +0200, Antoine Tenart wrote:
- /* disable ldo */
- clrbits_le32(&ccm->osc24m_cfg, OSC24M_LDO_EN);
I realise I'm the one who suggested doing this, but that might turn out to be wrong. Have you tested devices that use the oscillator directly, like the PWM?
No, and good point.
I think the sun4i-timer and ARM arch timer are also clocked from OSC24M, so turning it off is really not a good idea.
You're right, sun4i-timer is clocked from osc24m. Turning off LDO doesn't turn off OSC24M, but that might disturb it if I understood correctly. Anyway I won't disable LDO in v4.
That makes me wonder what the LDO is actually for...
ChenYu
Thanks!
Antoine
-- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com