Re: [U-Boot] [PATCH] new tool mkenvimage: generates an env image from an arbitrary config file

On Tuesday, August 09, 2011 06:31:29 David Wagner wrote:

+extern uint32_t crc32 (uint32_t, const unsigned char *, unsigned int);

does including u-boot/crc.h work ?

+static void usage(char *exec_name)

const char *exec_name

• char *txt_filename = NULL, *bin_filename = NULL;

mark them both const ?

• dataptr = calloc(datasize, sizeof(*dataptr));

you zero-ed it out here ...

• /* Pad the environnment with the padding byte */
• memset(envptr, padbyte, envsize);

... then manually filled it with a byte. just use malloc() instead of calloc() and avoid that zero.

• memcpy((uint32_t*) dataptr, &targetendian_crc, sizeof(uint32_t));

i dont think that cast is necessary. just punt it. -mike