8 Jul
2015
8 Jul
'15
5:35 a.m.
Hi Codrin,
On Thu, Jul 2, 2015 at 9:32 AM, Codrin Constantin Ciubotariu codrin.ciubotariu@freescale.com wrote:
Hi Joe,
-#define CONFIG_VSC9953_PORT_ENA 0x00003a00
Why is this value changing? Was it just wrong before?
Sorry, I missed this comment. Yes, the correct value that only enables the port is 0x00002000. The rest of the bits are set to 1 because they are reserved and default values. Since this patch changes the way l2qsys_reg->sys.switch_port_mode[i] is set (out_le32() replaced by setbits_le32()), the other bits are no longer touched when enabling the port:
OK. This is (obviously) unclear as is.
out_le32(&l2qsys_reg->sys.switch_port_mode[i],CONFIG_VSC9953_PORT_ENA);
setbits_le32(&l2qsys_reg->sys.switch_port_mode[i],CONFIG_VSC9953_PORT_ENA)Should I make a different patch for this change?
For sure. Include the comment you made above in the log.
Thanks, -Joe