Re: [U-Boot] [PATCH v2 04/29] Convert CONFIG_SYS_CONSOLE_IS_IN_ENV et al to Kconfig

On Sat, Sep 24, 2016 at 06:17:00PM -0600, Simon Glass wrote:

This converts the following to Kconfig: CONFIG_SYS_CONSOLE_IS_IN_ENV CONFIG_CONSOLE_MUX

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v2:

• Make CONSOLE_MUX default y if DM_VIDEO || VIDEO || LCD

README | 6 ------ common/Kconfig | 20 ++++++++++++++++++++

[snip]

diff --git a/common/Kconfig b/common/Kconfig index 6ee67ac..8e600f7 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -288,6 +288,26 @@ config PRE_CON_BUF_ADDR We should consider removing this option and allocating the memory in board_init_f_init_reserve() instead.

+config CONSOLE_MUX

• bool "Enable console multiplexing"
• default y if DM_VIDEO || VIDEO || LCD
• help

•  This allows multiple devices to be used for each console 'file'.
  

•  For example, stdout can be set to go to serial and video.
  

•  Similarly, stdin can be set to come from serial and keyboard.
  

•  Input can be provided from either source. Console multiplexing
  

•  adds a small amount of size to U-Boot.  Changes to the environment
  

•  variables stdout, stdin and stderr will take effect immediately.
  

+config SYS_CONSOLE_IS_IN_ENV

• bool "Select console devices from the environment"
• help

•  This allows multiple input/output devices to be set at boot time.
  

•  For example, if stdout is set to "serial,video" then output will
  

•  be sent to both the serial and video devices on boot. The
  

•  environment variables can be updated after boot to change the
  

•  input/output devices.
  

OK, it looks like we should say SYS_CONSOLE_IS_IN_ENV is default y if CONSOLE_MUX. This won't cover all of the defconfig additions (something else needs to be done for boards with > 1 uart and not all of that is in Kconfig yet either) but it will help.